Skip to content

[PM-44082] docs: additional refinements to iOS getting-started - #878

Merged
tomhartnett-bw merged 3 commits into
mainfrom
pm-44082-brew-bundle-step-2
Oct 7, 2026
Merged

tomhartnett-bw merged 3 commits into
mainfrom
pm-44082-brew-bundle-step-2

Conversation

@tomhartnett-bw

@tomhartnett-bw tomhartnett-bw commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-44082

📔 Objective

As a follow-up to #877, this PR makes additional refinements to the Getting Started page for iOS.

📸 Screenshots

@tomhartnett-bw
tomhartnett-bw requested a review from a team October 1, 2026 15:42
KatherineInCode
KatherineInCode previously approved these changes Oct 1, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c42c505
Status: ✅  Deploy successful!
Preview URL: https://e86eaaf7.contributing-docs.pages.dev
Branch Preview URL: https://pm-44082-brew-bundle-step-2.contributing-docs.pages.dev

View logs

@tomhartnett-bw
tomhartnett-bw marked this pull request as ready for review October 1, 2026 17:03
@tomhartnett-bw
tomhartnett-bw requested a review from a team as a code owner October 1, 2026 17:03
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

Documentation-only change to docs/getting-started/mobile/ios/index.md, following up on PR 877. It drops the Mint-specific callout and the non-brew Mint install path, marks the fastlane step optional, and standardizes directory references on "the repository root". The standardization reads well and the fastlane and Mint reductions are reasonable simplifications. One regression: removing cd ios leaves the setup sequence with no step that enters the cloned repository, so the first command a new contributor runs fails.

Code Review Details
  • ⚠️ : Setup steps no longer enter the cloned repo, so brew bundle runs in the parent directory
    • docs/getting-started/mobile/ios/index.md:25

Comment thread docs/getting-started/mobile/ios/index.md
@tomhartnett-bw
tomhartnett-bw force-pushed the pm-44082-brew-bundle-step-2 branch from 2b01c94 to e8786b1 Compare October 5, 2026 14:35
@tomhartnett-bw
tomhartnett-bw force-pushed the pm-44082-brew-bundle-step-2 branch from e8786b1 to c42c505 Compare October 7, 2026 13:47

@vvolkgang vvolkgang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomhartnett-bw
tomhartnett-bw merged commit eda44a7 into main Oct 7, 2026
15 checks passed
@tomhartnett-bw
tomhartnett-bw deleted the pm-44082-brew-bundle-step-2 branch October 7, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants