Skip to content

fix: wrong absmax indexing in AVX512 dequantizeBlockwise4bitCpu #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NanoCode012 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: wrong absmax indexing in AVX512 dequantizeBlockwise4bitCpu #2096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csrc/cpu_ops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ void dequantizeBlockwise4bitCpu(
long long absmax_dim_1 = dim_1 / blocksize;
using Tcomp = float;
constexpr auto VEC_LEN = sizeof(__m512i) / sizeof(Tcomp); // 16
if (dim_1 % VEC_LEN == 0 && blocksize >= VEC_LEN) {
if (dim_1 % VEC_LEN == 0 && blocksize >= VEC_LEN && dim_1 % blocksize == 0) {
__m512 lut = DATA_TYPE == 1 ? set_fp4_lut() : set_nf4_lut();
constexpr auto k_step = VEC_LEN / 2; // 8
BNB_OMP_PARALLEL_FOR
Expand Down