Skip to content

Percentile Clipping causes FutureWarning #1713

Closed

Description

@Avelina9X

When percentile clipping is set to a value below 100 it triggers a future warning as the underlying method used to calculate the clipping values has been marked as deprecated:

@deprecated("This function is deprecated and will be removed in a future release.", category=FutureWarning)

May I ask why this is? Is percentile clipping itself slated for removal?

Activity

  1. matthewdouglas commented on Jul 21, 2025

    @matthewdouglas
    Member

    Thanks for the feedback!

    Yes, percentile clipping itself is deprecated. We could make this more clear with a warning in the optimizers. Setting block_wise=False is a similar situation where we have marked a function it uses as deprecated in bitsandbytes.functional but it may be more clear if we warned when initializing an optimizer with it.

  2. added
    DocumentationImprovements or additions to documentation
    Contributions WelcomeWe welcome contributions to fix this issue!
    OptimizersIssues or feature requests relating to optimizers
    on Jul 21, 2025
  3. modified the milestones: , v0.47.0 on Jul 21, 2025
  4. TimDettmers commented on Feb 21, 2026

    @TimDettmers
    Collaborator

    Closing this as resolved. As matthewdouglas confirmed, percentile clipping is deprecated, which is why the underlying function triggers a FutureWarning. This is by design. A clearer deprecation warning at optimizer initialization time would improve the UX, but the behavior is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Contributions WelcomeWe welcome contributions to fix this issue!DocumentationImprovements or additions to documentationOptimizersIssues or feature requests relating to optimizers

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions