Floor rustls to v0.23.45 to patch RUSTSEC-2026-0285 - #256
Open
luisschwab wants to merge 1 commit into
Open
luisschwab wants to merge 1 commit into
luisschwab wants to merge 1 commit into
Conversation
| openssl = { version = "0.10.78" } # blame: match `openssl-sys` (multiple RUSTSECs) | ||
| openssl-sys = { version = "0.9.114" } # blame: bitreq@0.3.7 -> native-tls@0.3.0 -> openssl@0.10.15 (multiple RUSTSECs) | ||
| ring = { version = "0.17.12" } # blame: bitreq@0.3.7 -> tokio-rustls@0.26.4 -> rustls@0.23.38-> rustls-webpki@0.103.13 -> ring@0.17.0 (RUSTSEC-2025-0009) | ||
| rustls = { version = "0.23.45" } # blame: bitreq@0.3.7 -> rustls@0.23.43 (RUSTSEC-2026-0285) |
Contributor
There was a problem hiding this comment.
@luisschwab Do we need to only bump the dev-dependencies ?
Member
Author
There was a problem hiding this comment.
cargo-audit is not complaining, but I'll check if the broken version will get pulled in on a downstream project. AFAIK 0.23.45 would be pulled, since the whole dep tree, including dev-deps, are pulled in by dependants.
Member
Author
There was a problem hiding this comment.
I've tested it locally and a downstream of esplora-client does not pull in the vulnerable rustls version.
cargo tree -i rustls
rustls v0.23.45
└── bitreq v0.3.7
[build-dependencies]
└── halfin v0.5.0 (/Users/luisschwab/git/halfin)
[build-dependencies]
└── halfin v0.5.0 (/Users/luisschwab/git/halfin)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
Changelog