feat: add frigate electrum based RPC methods - #16
Open
sdmg15 wants to merge 9 commits into
Open
Conversation
sdmg15
changed the title
server.version, blockchain.silentpayments.subscribe and blockchain.silentpayments.unsubscribe
sdmg15
force-pushed
the
master
branch
2 times, most recently
from
April 30, 2026 17:00
225fc0c to
885cd2f
Compare
sdmg15
marked this pull request as ready for review
May 1, 2026 14:32
- Add `ServerVersion` request type (`server.version`) - Add optional `mode` parameter to `EstimateFee` (breaking: new field) - Support both pre-1.6 (concatenated hex) and v1.6 (list of hex strings) response formats for `blockchain.block.headers` - Add `BroadcastPackage` request type (`blockchain.transaction.broadcast_package`) - Add `GetMempoolInfo` request type (`mempool.get_info`) - Add missing `Features` to `gen_pending_request_types!` macro Closes bitcoindevkit#8 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Cover both the pre-1.6 concatenated-hex path and the v1.6 array-of-hex path, asserting they produce equal `Vec<Header>`, plus a sanity check that non-string/non-array inputs are rejected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Thanks for the PR! Note that it needs a rebase now with the recent merges. |
evanlinjin
requested changes
May 7, 2026
oleonardolima
left a comment
oleonardolima
left a comment
Contributor
There was a problem hiding this comment.
In https://github.com/sparrowwallet/frigate#serverfeatures it mentions the new field in server.features, is it not needed by bdk-sp ?
Contributor
|
@sdmg15 I just thought this now during the call, but you could also try adding support for these in https://github.com/bitcoindevkit/rust-electrum-client, not sure if the architecture there supports it though. |
noahjoeris
requested changes
Jul 21, 2026
Capture rejection details when package broadcast fails, and simplify broadcast hex encoding with serialize_hex.
mempool.get_info returns required BTC/kvB floats, so deserialize to FeeRate directly and share conversion with the estimatefee opt helper.
Use blockchain.relayfee in docs and switch the README sample to GetMempoolInfo for v1.6.
noahjoeris
requested changes
Aug 3, 2026
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
Thanks for updating @sdmg15 !
I left a few more comments
Author
|
@noahjoeris Thanks for the reviews. I've applied the changes. |
noahjoeris
requested changes
Aug 10, 2026
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
Thanks again for updating man. Almost there 🚀
Could you also add doc comments to the pub fields you added?
noahjoeris
self-requested a review
August 25, 2026 18:31
noahjoeris
requested changes
Aug 26, 2026
|
Thanks @sdmg15 . I left some final nits. And I ran a quick manual test and it was looking good. |
noahjoeris
requested changes
Aug 31, 2026
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
tACK on the code. Manually tested against Frigate 1.4.1 on regtest with sp txs.
Before merge, please fold the history into:
feat: support attributes in gen_pending_request_types!feat: add Frigate Silent Payments RPC support
Also left some docs update suggestions (non-blocking).
Thanks for all the updates
sdmg15
force-pushed
the
master
branch
2 times, most recently
from
August 31, 2026 12:56
d93c094 to
7b1017a
Compare
noahjoeris
reviewed
Sep 1, 2026
noahjoeris
approved these changes
Sep 1, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds supports for additional RPC methods provided by Frigate electrum based RPC server.
The added methods are:
server.version: This is the first message sent to establish connection with serverblockchain.silentpayments.subscribe: This takes a spend public key and a scan private key and return outputs belonging to the them.blockchain.silentpayments.unsubscribe: This takes a spend public key and a scan private key and unsubscribe from notifications.Some context:
This is useful for the PR opened at bitcoindevkit/bdk-sp#48 which is doing integration of frigate ephemeral scanning.
Opening this PR in order to receive feedback.
Reference:
https://github.com/sparrowwallet/frigate/
Supported Frigate version 1.3.2