Update libmultiprocess subtree in 30.x branch - #33519
Merged
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33519. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
a4f9296 Merge bitcoin-core/libmultiprocess#224: doc: fix typos f4344ae Merge bitcoin-core/libmultiprocess#222: test, ci: Fix threadsanitizer errors in mptest 1434642 doc: fix typos 73d22ba test: Fix tsan race in thread busy test b74e1bb ci: Use tsan-instrumented cap'n proto in sanitizers job c332774 test: Fix failing exception check in new thread busy test ca3c05d test: Use KJ_LOG instead of std::cout for logging 7eb1da1 ci: Use tsan-instrumented libcxx in sanitizers job ec86e43 Merge bitcoin-core/libmultiprocess#220: Add log levels and advertise them to users via logging callback 515ce93 Logging: Pass LogData struct to logging callback 213574c Logging: reclassify remaining log messages e4de041 Logging: Break out expensive log messages and classify them as Trace 408874a Logging: Use new logging macros 67b092d Logging: Disable logging if messsage level is less than the requested level d0a1ba7 Logging: add log levels to mirror Core's 463a829 Logging: Disable moving or copying Logger 83a2e10 Logging: Add an EventLoop constructor to allow for user-specified log options 58cf47a Merge bitcoin-core/libmultiprocess#221: test default PassField impl handles output parameters db03a66 Merge bitcoin-core/libmultiprocess#214: Fix crash on simultaneous IPC calls using the same thread afcc40b Merge bitcoin-core/libmultiprocess#213: util+doc: Clearer errors when attempting to run examples + polished docs 6db6696 test In|Out parameter 29cf2ad test default PassField impl handles output parameters 1238170 test: simultaneous IPC calls using same thread eb069ab Fix crash on simultaneous IPC calls using the same thread ec03a96 doc: Precision and typos 2b43481 doc: Where possible, remove links to ryanofsky/bitcoin/ 286fe46 util: Add helpful error message when failing to execute file 47d79db Merge bitcoin-core/libmultiprocess#201: bug: fix mptest hang, ProxyClient<Thread> deadlock in disconnect handler f15ae9c Merge bitcoin-core/libmultiprocess#211: Add .gitignore 4a269b2 bug: fix ProxyClient<Thread> deadlock if disconnected as IPC call is returning 85df964 Use try_emplace in SetThread instead of threads.find ca9b380 Use std::optional in ConnThreads to allow shortening locks 9b07991 doc: describe ThreadContext struct and synchronization requirements d60db60 proxy-io.h: add Waiter::m_mutex thread safety annotations 4e365b0 ci: Use -Wthread-safety not -Wthread-safety-analysis 15d7baf Add .gitignore fe1cd8c Merge bitcoin-core/libmultiprocess#208: ci: Test minimum cmake version in olddeps job b713a0b Merge bitcoin-core/libmultiprocess#207: ci: output CMake version in CI script 0f58039 ci: Test minimum cmake version in olddeps job d603dcc ci: output CMake version in CI script git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: a4f9296
ryanofsky
force-pushed
the
pr/subtree-6-v30
branch
from
October 7, 2025 14:22
8c0c0bf to
ae63cc4
Compare
Contributor
Author
|
Updated 8c0c0bf -> ae63cc4 ( |
ryanofsky
marked this pull request as ready for review
October 7, 2025 14:23
Member
Member
|
Since it missed the 30.0 cut-off, should we wait a bit longer? |
Member
For anything in particular? There are backports that are blocked on this, so it seems more useful to pull this now, and unblock them. It can always be pulled again later if there is a reason to do so. |
Member
|
ACK ae63cc4 |
Member
|
Added to |
This was referenced Oct 27, 2025
Merged
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
abcd4c4 Squashed 'src/ipc/libmultiprocess/' changes from 13424cf..a4f9296 (Ryan Ofsky) Pull request description: Includes: - bitcoin-core/libmultiprocess#207 - bitcoin-core/libmultiprocess#208 - bitcoin-core/libmultiprocess#211 - bitcoin-core/libmultiprocess#201 - bitcoin-core/libmultiprocess#213 - bitcoin-core/libmultiprocess#214 - bitcoin-core/libmultiprocess#221 - bitcoin-core/libmultiprocess#220 - bitcoin-core/libmultiprocess#222 - bitcoin-core/libmultiprocess#224 Corresponding to bitcoin#32641 and bitcoin#33518 in master. The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees) and [lint instructions](https://github.com/bitcoin/bitcoin/tree/master/test/lint#git-subtree-checksh) They can also be verified by checking `src/ipc/libmultiprocess/` contents are the same in master. (See also bitcoin#33439). ACKs for top commit: Sjors: ACK 7788449 theuni: ACK 7788449 . Verified that it's the same as what's in master. Tree-SHA512: 6c9462d5fb9201ee8ace900d7d02bfb6d0c7aa3d2f22475dc55e55e0239e2d20ed69f572c0df233da7910375e9d8ccaf3e84bf949ae92df27b88f16adb26dd7a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
Corresponding to #32641 and #33518 in master.
The changes can be verified by running
test/lint/git-subtree-check.sh src/ipc/libmultiprocessas described in developer notes and lint instructionsThey can also be verified by checking
src/ipc/libmultiprocess/contents are the same in master. (See also #33439).