BIP-352: clarify silent payment address length - #2271
Open
notTanveer wants to merge 1 commit into
Open
Conversation
notTanveer
force-pushed
the
fix/sp-addr-len
branch
from
September 2, 2026 19:37
66c0c6d to
2ec04a0
Compare
murchandamus
added
the
Fixups
murchandamus
reviewed
Sep 4, 2026
murchandamus
left a comment
murchandamus
left a comment
Member
There was a problem hiding this comment.
LGTM, will merge in a few days if I don’t hear otherwise.
cc: @theStack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the address length note only gave 117 chars as the number to check against, using a 3-char HRP as the example without saying mainnet uses "sp" (2 chars, 116 total).