cmake: add type-unordered-set.h and version.h to public headers - #350
Merged
Conversation
This ensures all headers are properly installed, and is useful for building bitcoin core with WITH_EXTERNAL_LIBMULTIPROCESS.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste |
hebasto
approved these changes
Aug 23, 2026
| include/mp/type-void.h | ||
| include/mp/util.h) | ||
| include/mp/util.h | ||
| include/mp/version.h) |
Member
There was a problem hiding this comment.
Agreed. In the Bitcoin Core repo:
$ git grep "mp/version.h" -- ":(exclude)src/ipc/libmultiprocess/"
src/ipc/util.h:#include <mp/version.h>| include/mp/type-struct.h | ||
| include/mp/type-threadmap.h | ||
| include/mp/type-tuple.h | ||
| include/mp/type-unordered-set.h |
Member
There was a problem hiding this comment.
This header doesn't seem to be used in Bitcoin Core outside of src/ipc/libmultiprocess/:
$ git grep "mp/type-unordered-set.h" -- ":(exclude)src/ipc/libmultiprocess/" | wc -l
0However, it's better to treat it like the other mp/type-*.h headers. This line effectively amends #277.
Contributor
|
ACK 2448d28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are useful for building bitcoin core with WITH_EXTERNAL_LIBMULTIPROCESS and having the install target install the complete set of public headers more generally.