COLDCARD edge taproot - #725
Closed
scgbckbone wants to merge 1 commit into
Closed
Conversation
Member
|
#849 includes this change (partially) |
achow101
added a commit
that referenced
this pull request
Aug 20, 2026
…s, restore test_signtx (ex. multisig) aa3e733 ci: add finite APT connection timeouts/retries (Sjors Provoost) 90b7b0a ci: bump GitHub Actions versions (Sjors Provoost) f8bd294 coldcard: preserve PSBTv2 when supported (Sjors Provoost) e5aa9cc coldcard: display singlesig taproot address on EDGE (Sjors Provoost) 534468c ci: run Coldcard Edge simulator tests (Sjors Provoost) 454e36e ci: parameterize device test matrix (Sjors Provoost) 2cda52a test: support Coldcard Edge in device tests (Sjors Provoost) 8dc9a6f ci: build Coldcard Edge simulator (Sjors Provoost) 57b062e test: factor out Coldcard firmware setup (Sjors Provoost) 9b420ea test: limit Coldcard simulator checkout (Sjors Provoost) 893818a test: bump Coldcard firmware to 5.6.0 (Sjors Provoost) 257e1ae test: reenable Coldcard singlesig transaction signing (Sjors Provoost) Pull request description: The Edge firmware supports displaying taproot single sig addresses, and more importantly MuSig2. Rather than blowing up the CI matrix, this PR only adds it for Python 3.14. It can be easily be dropped again if all Edge features we care about land in their regular firmware. The first commit re-enables `test_signtx`, which was already possible. It achieves this by dropping multisig for ColdCard in that these. This can be re-introduced by #792. The multisig patch is adjusted or Edge. Alternatively after #847 it could be dropped entirely. It builds, but CI won't cover it until #792. I did test it locally. - fixes #799 - fixes #703 - superseedes #833 - superseedes #725 ACKs for top commit: achow101: ACK aa3e733 Tree-SHA512: e67745bdea35c9d6d6515d83daecbb2f750bf925f403e03b102e4996b9a56194b4b7a4316d44565ab2a1768a2bb6b0a19068e7bfe2cedca829c6d39006329c66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edgegit clonethat is run twice (maybe withgit worktree)