chore: rearrange structs a bit to shave bytes#1645
Open
0xf0xx0 wants to merge 4 commits into
Open
Conversation
0xf0xx0
commented
Apr 1, 2026
| uint64_t shares_rejected; | ||
| uint64_t work_received; | ||
| RejectedReasonStat rejected_reason_stats[10]; | ||
| uint32_t shares_accepted; |
Collaborator
Author
There was a problem hiding this comment.
dropped these to uint32s, should be fine
assuming a share a second itd take 180 years to hit 2^32
Collaborator
|
@0xf0xx0 please resolve conflicts :-) |
reduced padding to 4 bytes all at the end
Collaborator
Author
|
fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
im not sure how to calculate how much this actually saves, mayb like 20 bytes lol
used https://staruwos.github.io/structviz/