feat(BBBModal): add hideCloseButton prop to hide header close button - #79
Merged
Merged
Conversation
BBBModal always renders a close button in the header, with no way to suppress it. This blocks use cases that require a non-dismissible modal, such as mandatory-action dialogs or modals whose closing is controlled entirely by external logic. Add a hideCloseButton prop (default false) that conditionally renders the close button, following the same pattern already used by noFooter.
styles.ts defines a CloseButton styled-component that is never referenced: the modal's close button has always been rendered via BBButton in component.tsx instead. Remove the dead code.
Arthurk12
changed the title
hideCloseButton prop to hide header close button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
BBBModal always renders a close button in the header, with no way to suppress it. This blocks use cases that require a non-dismissible modal, such as mandatory-action dialogs or modals whose closing is controlled entirely by external logic.
Add a hideCloseButton prop (default false) that conditionally renders the close button, following the same pattern already used by noFooter.
Additionally:
styles.ts defines a CloseButton styled-component that is never referenced: the modal's close button has always been rendered via BBButton in component.tsx instead. Remove the dead code.
Closes Issue(s)
Closes #76