fix(BBButton): make size resize circle and squared layouts - #78
Merged
Merged
Conversation
`circle` hardcoded a 3rem width/height regardless of `size`, and `squared` hardcoded its padding, overriding the size-derived padding from commonButtonStyles — both contradicted the `size` doc, which claims it affects padding and the circle's diameter. Add a shared `iconBoxSize` per size to CSS_SIZE_PROPERTIES and an `iconOnlyBoxStyles` fragment reused by both layouts, so `circle` and `squared` always render at the same fixed box size for a given `size` (sm: 2rem, md: 3rem, the latter promoted to a new `spacingXXLarge` token to match the previous circle default). This changes squared's default look: it no longer sizes itself from icon + padding, and now matches circle's box size instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
circlehardcoded a 3rem width/height regardless ofsize, andsquaredhardcoded its padding, overriding the size-derived padding from commonButtonStyles — both contradicted thesizedoc, which claims it affects padding and the circle's diameter.Add a shared
iconBoxSizeper size to CSS_SIZE_PROPERTIES and aniconOnlyBoxStylesfragment reused by both layouts, socircleandsquaredalways render at the same fixed box size for a givensize(sm: 2rem, md: 3rem, the latter promoted to a newspacingXXLargetoken to match the previous circle default). This changes squared's default look: it no longer sizes itself from icon + padding, and now matches circle's box size instead.Closes Issue(s)
Closes #74