Repository navigation
Fix SOCKS proxy follow-ups for dialogs, persistent sessions and errors - #337
Merged
Merged
Conversation
A persistent tmux session can only be resumed over the proxy it was opened through, so deleting that proxy is refused while such a session exists. Listing proxies no longer consumes the connection mutation budget, which could make every routed host appear to have a missing proxy. A blocked proxy endpoint is now reported as a proxy failure, and failure replies are evaluated before the bound address so truncated replies keep their reason.
The manage button opened the proxy view behind the still open connection dialog. Opening any connection resource now leaves the dialog first. Routes applied by reconnect or history now clear and lock the other route selector, a rejected save reports its error once, and deletion blocked by persistent sessions names them.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #336.
Changes
Connection dialog
Persistent sessions
Server
list_socks_proxiesno longer consumes the connection mutation budget (same aslist_jump_hosts). A throttled list made every routed host show "SOCKS5 proxy missing".SOCKS5 proxy: …, distinguishable from a blocked target.Docs
Security notes
No change to routing, DNS policy, credential binding or fail-closed behaviour. The deletion check only adds a refusal. A session created concurrently with a deletion ends in the same fail-closed state as before.
Tests
main.