Repository navigation
Show project support links and translate remaining workspace strings - #331
Merged
Merged
Conversation
The Settings side panel lists GitHub Sponsors, Patreon and Buy Me a Coffee below the account and version facts. The side panel only appears on wide screens, so the account menu also links to the repository's sponsor dialog, which lists the same profiles. The links open in a new tab without access to the WebSSH window and load nothing from external sites until a user follows one. Administrators can hide the links for all users under Administration -> Integrations. The setting is shown by default, stored in app_settings.json and changed through the existing step-up protected settings endpoint. Older versions ignore the additional key.
Several labels stayed English regardless of the selected language: the truncated file preview notice, the image preview alt text, one connection resources navigation label, the Bash activation command field, the cancel button on a connecting tab, the tmux badge tooltip, the SSH key validation message, the drop hint without a session, and the file manager quick connect password field. They now use existing keys where one fits and new keys in all six languages otherwise. The quick connect dialog also translates placeholders now. Decorative icons in the touched markup are hidden from screen readers.
The SMB dialog used --primary-color and --danger-color, which no stylesheet defines, so the error and pending status and the security note icon fell back to the inherited text colour. They now use the theme's --accent-primary and --error-color. Remove the .session-cpu-gauge rules: the gauge left the templates and scripts earlier and its rules were the only other use of an undefined property. A test now fails when a stylesheet uses var() without a fallback for a property nothing defines.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and outcome
WebSSH has funding profiles in
.github/FUNDING.yml, but the application never pointed users to them. The Settings side panel now lists GitHub Sponsors, Patreon and Buy Me a Coffee below the account and version facts. That panel only appears at 1500px and wider, so the account menu also links to the repository's sponsor dialog (?sponsor=1), which lists the same profiles.The links open in a new tab with
rel="noopener noreferrer"and load nothing external until a user follows one. Administrators of company or customer instances can hide them for all users under Administration → Integrations → Project support links.A review of the frontend found small defects that are fixed in separate commits:
--primary-colorand--danger-color, which nothing defines, so its error and pending status lost their colour. Unused.session-cpu-gaugerules, the only other user of an undefined property, are removed.Scope and links
Related issue/proposal: none
Target milestone (if accepted into a release): next minor release
Validation
pytest: everything except tests that cannot run in this environment passes. The automation cron/schedule tests fail locally withZoneInfoNotFoundError(tzdata missing from the local virtualenv), andtest_pytest_shardfails only under xdist; it passes on its own. The first commit was also tested on its own (test_security_ui,test_admin_routes,test_i18n_parity,test_version).account-menu,admin-keyboard-auth,file-workspace,primary-workspace-navigation,profile-launcher,session-workspace,smb-file-workspace), plusaccount-theme-matrixandssh-gateway.npm run test:jspasses exceptautomation-tools.test.js"maintenance template runs exactly the probe", which fails only on a Windows CRLF checkout and is unrelated.FUNDING.yml, includingnoopener/noreferrer.window.opener.var()without a fallback for an undefined custom property.support_links_enabledis an additional optional boolean inapp_settings.json. A missing key means shown. Older versions ignore the key, so backups restore in both directions./admin/api/settingsendpoint with thesettings.updatestep-up and is logged.aria-labels, because its own translation helper does not handle aria labels yet. That is left for a separate change.Delivery
Merging implements the change; it does not publish a versioned release.