Repository navigation
Recheck the restart marker on login while a restart hint is shown - #321
Merged
Merged
Conversation
The restart hint from the Updates and restart status check stayed until the template ran again, so a host kept showing "Restart required" after it had been restarted. While a saved host shows that hint, the next login rereads only the restart marker (two existence tests, no sudo, no writes). Exactly "reboot=no" lowers the hint; exactly "reboot=yes" keeps it for the next login. Any other answer or none keeps the hint and stops the rereads until the next full check, since a forced command may have answered. Hosts without a hint are never asked. The write only applies while the stored check is still the one that was read, so a newer check is never overwritten. The restart item in the overview also offers to open the check again as a draft for the hosts concerned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The restart hint written by the Updates and restart status template stayed until the template ran again. After a restart, and even after logging in again, the overview still showed "Restart required" for up to a week.
Change
[ -e /var/run/reboot-required ] || [ -e /run/reboot-required ]. No sudo, no package manager, no writes.reboot=nolowers the hint toFalse. Update counts and the check time stay as the last full check reported them.reboot=yeskeeps the hint and asks again on the next login.command=inauthorized_keys,ForceCommand) may have answered in place of the test and must not run on every login.Security notes
host_maintenancesocket event carries just the profile id and goes only to the connecting client.Tests
reboot=yesorreboot=nowith empty stderr.