Implement draggable points on the EQ graph#29
Merged
Conversation
Contributor
jtl5770
commented
May 19, 2026
- Add coordinate conversion helpers (y_to_db)
- Implement drag gesture handlers for real-time frequency and gain adjustment
- Account for combined curve response and shelf filter correction during drags
- Batch UI updates for smoother performance
- Connect Gtk.GestureDrag to the graph area
bhack
reviewed
May 19, 2026
There was a problem hiding this comment.
Pull request overview
Adds interactive drag controls to the EQ graph so users can adjust a band’s frequency/gain by dragging the on-curve point, with coordinate conversion helpers and batched UI/engine updates to keep interaction smooth.
Changes:
- Wire up
Gtk.GestureDragon the graph drawing area to begin/update/end drag interactions. - Implement drag handlers that pick the nearest visible band point and update band frequency/gain in real time (including shelf correction).
- Add
y_to_db()to invert the existingdb_to_y()mapping for pointer→dB conversion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/mini_eq/window_layout.py |
Attaches a Gtk.GestureDrag controller to the EQ graph area and connects it to the new handlers. |
src/mini_eq/window_graph.py |
Implements drag selection + updates, and adds y_to_db() for coordinate conversion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I've updated the PR with the following changes:
|
Owner
|
Ok I've just extended the test coverage. let's see the CI |
Add graph drag handlers for real-time frequency and gain adjustment, keep click and drag coordinate mapping aligned, preserve solo context while calculating drag deltas, and support Shift+vertical drag for Q adjustment.
639662f to
1499b64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.