fix: form-builder multistep data parsing#119
Merged
olliethedev merged 2 commits intomainfrom Apr 17, 2026
Merged
Conversation
…with better multi-step support
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Security Review — No High-Confidence Vulnerabilities Found
This PR is a targeted bug fix for form-builder multi-step schema parsing. After reviewing the full diff against each threat category, no exploitable security vulnerabilities were identified.
Threat Evaluation
| Area | Finding |
|---|---|
| Injection (SQL / command / path traversal) | No server-side execution, filesystem access, or DB queries. Values from stepGroupMap are integer step indices only. |
| Prototype pollution | Lookup is stepGroupMap?.[key] where key is always derived from iterating schema.properties. The map's own keys are never used to write to other objects. |
| Authn / authz | No permission checks added or removed. |
| Secrets / token leakage | No secrets or tokens involved. |
| Unsafe deserialization / XSS | stepGroupMap values feed into field.stepGroup (a tab-selection index), not into HTML rendering. No XSS surface. |
| Supply-chain / dependencies | No new dependencies introduced. |
Notes
- The new
stepGroupMaptype isRecord<string, number>. At runtime, a malformed schema could supply non-numeric values; however the impact is limited to incorrect step-tab assignment in the UI — no injection or escalation path exists. - The new
@workspace/ui/components/form-builder/schema-utilsexport path exposes an existing internal module publicly. The module contains no privileged logic or sensitive data. - Test coverage for the new code path is comprehensive (both encoding paths, precedence, and round-trips).
No remediation required for this PR.
Sent by Cursor Automation: Find vulnerabilities
Contributor
|
✅ Shadcn registry updated — registry JSON files were rebuilt and committed to this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Checklist
pnpm buildpassespnpm typecheckpassespnpm lintpassesdocs/content/docs/) if consumer-facing types or behavior changedScreenshots
Note
Medium Risk
Changes schema I/O behavior and public types for form-builder multi-step forms; incorrect mapping could misplace fields across steps, but scope is limited and covered by new unit tests.
Overview
Fixes multi-step form-builder schema parsing to support Zod-generated schemas that encode step placement via a root-level
stepGroupMap, while keeping per-propertystepGroupas the preferred source.Updates
JSONSchematypings to includestepGroupMap, threads it throughjsonSchemaToFieldsAndSteps/propertiesToFields(including fallback fields), and adds a dedicated export (@workspace/ui/components/form-builder/schema-utils) plus comprehensive regression/round-trip tests. Also bumps@btst/stackversion to2.11.6.Reviewed by Cursor Bugbot for commit 2b2432c. Bugbot is set up for automated code reviews on this repo. Configure here.