Repository navigation
Conversation
toprameen
marked this pull request as ready for review
November 19, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map.hasreuses the key cursor fromMap.getso deeper splits can resume from the previous character.Set.hasuses the same path. The extended fixture checks hits through both recursive branches and misses with long and short queries.Median times from alternating local runs with prebuilt queries and 50% hits:
The two-key case pays to initialize a suffix and reaches a leaf immediately. I kept the cursor implementation for the gains on deeper tries and included the shallow native cost above.