Repository navigation
Conversation
toprameen
marked this pull request as ready for review
November 18, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful
IO.withincall can leave its deadline sleep running after the program has finished its work. Positive deadlines now useChan.try_recvon the action’s result channel, so receiving the result retires the pending timer. A timed-out action still runs to completion, and a zero deadline keeps the existing race.Positive deadlines now start when the caller begins waiting. If the event loop resumes after the deadline, the timeout can win before the action’s queued continuation sends its result.
On macOS arm64 with Apple Clang 21, the native
tests/io/within.bendfixture with an eight-second deadline took 8.05 s on upstream and 0.17 s with the patch. These are single end-to-end runs for each build, including process startup. Both produced identical output.The extended fixture checks an early result, a zero-deadline winner, and completion of a timed-out action. Under the five-second test alarm, upstream times out and the patch passes on macOS and Linux arm64. The local repository gate passes 56/56, and the fixture passes
--verdict.