Repository navigation
Fix Bend source imports on Node with default type stripping - #2204
Open
sebastian-griego wants to merge 1 commit into
Open
sebastian-griego wants to merge 1 commit into
sebastian-griego wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 24.15.0 stops with
ERR_UNSUPPORTED_TYPESCRIPT_SYNTAXwhen an application preloadsbend2/main.tsto import a Bend module. Node strips TypeScript types by default. The two constructor parameter properties in the loader's imports require a transform.Store the original check error in an explicit field. For recursive groups, use the key that the existing error already stores in its message. The module export test now imports its Bend source under Node when Node supports type stripping.
Verification
Run this command from the repository root with Node 24.15.0.
node --import ./bend2/main.ts --input-type=module -e 'import Game from "./demos/app_win_is_bug_2d/main.bend"; console.log(Game.map_h())'On
main, Node stops before it loads the game. With this change, it prints8.21968444and passed with this change. I ran it through the Bend CLI and as emitted JavaScript.tests/proof/group_*.bendfixtures emitted the same BendTT output asmain.