chore: rename task.md 'environment:' key to 'sandbox:' - #28
Merged
Conversation
benchflow is renaming the top-level task-config frontmatter key 'environment:' to 'sandbox:' (hard rename, no alias once it lands). Current benchflow releases (0.6.6 and 0.6.7.dev main) accept both spellings, so this migration is safe to merge immediately on any released version; it future-proofs env0 for the hard rename, after which only 'sandbox:' will parse. Scope: the top-level frontmatter key in all 68 task.md files under tasks/ and example_tasks/. The 'benchflow.environment.manifest' orchestration key is a different subsystem (Environment-plane manifest binding) and is intentionally unchanged, as are _manifests/*.toml and docs prose about the mock-services environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
benchflow is renaming the top-level task-config frontmatter key
environment:tosandbox:. This will be a hard rename (no alias): once it lands in benchflow, onlysandbox:will parse.Current benchflow — released 0.6.6 and 0.6.7.dev main — accepts both spellings, so this PR is safe to merge immediately on any version. Migrating now future-proofs env0 for the hard rename with zero breakage during the compatibility window.
What changed
task.mdfiles undertasks/andexample_tasks/: the top-level frontmatter keyenvironment:→sandbox:(one line per file, values untouched).Explicitly unchanged
benchflow.environment.manifest(theenvironment:sub-key nested under thebenchflow:orchestration section) — this is a different subsystem (the Environment-plane manifest binding), not the sandbox resource config. All 68 occurrences verified unchanged.tasks/_manifests/*.tomlVerification
git grep '^environment:'over task.md files now returns nothing;sandbox:count is 68.benchflow.environmentoccurrences: 68 before == 68 after;manifestoccurrences in .md: 77 before == 77 after.tasks/gdoc-search-keyword-index,tasks/stripe-balance-reconciliation,example_tasks/multi-misread-approval-scope) with current benchflow main (0.6.7.dev0) viabenchflow.task.document.TaskDocument.from_path: all parse, thesandbox:values land inTaskConfig(cpus/memory_mb/network_mode/os/storage_mb/gpus all correct, confirmed non-default by mutation test), andbenchflow.environment.manifeststill resolves.