You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normalizes google/gemini-* to the bare Gemini model ID only when configuring the Gemini ACP agent.
Root cause
Gemini CLI expects a bare model name. BenchFlow retained the models.dev google/ prefix, causing Gemini CLI to construct an invalid models/google/gemini-* path.
Impact
Provider-qualified Gemini model IDs work with the Gemini ACP agent; provider/model agents retain their existing prefix behavior.
Validation
uv run python -m pytest tests/test_acp.py -k 'TestConnectAcpModelSelection'
uv run ruff check src/benchflow/acp/runtime.py tests/test_acp.py
I reproduced the model-prefix behavior from #975 locally and compared the merge-base (29c64e7), the isolated Gemini fix commit (771be99), and the current PR head (bc9a1c3).
On the merge-base, gemini + google/gemini-2.5-pro stays as google/gemini-2.5-pro. With the Gemini fix, it becomes gemini-2.5-pro, and the current PR head behaves identically to the isolated fix commit.
I also checked the surrounding non-regression cases: an already-bare Gemini model stays bare, OpenCode still maps gemini-2.5-pro to google/gemini-2.5-pro, and google/gemma-* is left unchanged for Gemini.
The ACP test suite passed on my setup (94 passed, 1 skipped), and the four files touched by the PR pass both ruff check and ruff format --check.
Everything behaved as expected in the offline path I tested. I didn't run a live Gemini CLI call because I don't have a GEMINI_API_KEY, so I didn't independently verify the bare model ID against the real Gemini CLI.
Thanks @Galius5136! I found other gemini issues as well, so I'd probably update on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizes
google/gemini-*to the bare Gemini model ID only when configuring the Gemini ACP agent.Root cause
Gemini CLI expects a bare model name. BenchFlow retained the models.dev
google/prefix, causing Gemini CLI to construct an invalidmodels/google/gemini-*path.Impact
Provider-qualified Gemini model IDs work with the Gemini ACP agent; provider/model agents retain their existing prefix behavior.
Validation
uv run python -m pytest tests/test_acp.py -k 'TestConnectAcpModelSelection'uv run ruff check src/benchflow/acp/runtime.py tests/test_acp.pygit diff --checkFixes #975.