Repository navigation
Conversation
freakboy3742
requested changes
Nov 9, 2026
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! The approach you've taken here looks correct; the only suggestion I'd make would be that is_doc_url should be a method on the Deck, rather than a free-standing method.
Member
|
As for your question about opening links in the system browser - if you can make that work, it definitely sounds preferable to silently swallowing the click. My only concern would be what happens when the app is in presentation mode... but I guess in presentation mode you don't have a cursor, so this might not be an issue? If you can confirm this isn't a problem in practice, and you can implement the "open in system browser" approach, then go for it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the slides and speaker-notes WebViews now have an
on_navigation_startinghandler that only allows navigation to URLs served by the deck. Navigation to any other URL is cancelled.Testing
on_navigation_startingthereClicking an external link in a slide or the speaker notes navigated the window away from the presentation, with no way to get back.
Fixes #36
Question: With this change, clicking an external link does nothing. Would it be better to open blocked links in the system browser instead?
PR Checklist:
Assisted-by: Claude Opus 5.5