Don't reopen stdout against the console if it's already redirected - #126
Merged
Merged
Conversation
Briefcase needs to redirect output from the app so it can read test suite results and other log-based exit conditions. If the process has been run connected to a pipe, we need to keep stdout as is; otherwise, reopen so that console output isn't lost.
2 of 3 tasks
Member
Author
|
I've run the Python 3.14 PySide6 on ARM test 20 times in succession, and it has passed without an error. That isn't perfect evidence the issue is resolved, but it's a strong suggestion. |
Member
Author
|
I've also tested that this doesn't invalidate the change from #88 - if you manually run the app, it immediately returns to the command prompt, but stdout is still visible. |
mhsmith
approved these changes
Sep 21, 2026
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefcase needs to redirect output from the app so it can read test suite results and other log-based exit conditions. If the process has been run connected to a pipe, we need to keep stdout as is; otherwise, reopen so that console output isn't lost.
Refs beeware/briefcase#2969
PR Checklist:
Assisted-by: Claude Opus 5