Skip to content

32959 business emailer - alteration email bug fix #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kialj876 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

32959 business emailer - alteration email bug fix #4547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions queue_services/business-emailer/src/business_emailer/email_processors/filing_notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,14 @@ def _get_additional_info(filing: Filing) -> dict:

def _get_additional_recipients(filing: Filing, token: str) -> str:
"""Get additional recipients for a filing type."""
recipients = None
submitter_recipient_filings = ["alteration", "changeOfRegistration", "dissolution", "specialResolution"]
if filing.filing_type in submitter_recipient_filings:
optional_email = filing.filing_json["filing"]["header"].get("documentOptionalEmail")
if filing.submitter_roles and UserRoles.staff in filing.submitter_roles and optional_email:
# when staff do filing documentOptionalEmail may contain completing party email
recipients = f"{recipients}, {optional_email}"
return optional_email
else:
user_email = get_user_email_from_auth(filing.filing_submitter.username, token)
recipients = f"{recipients}, {user_email}"

return recipients
return get_user_email_from_auth(filing.filing_submitter.username, token)


def _get_attachments_and_extra_pdf_types(status: str, filing_type: str, filing: Filing, legal_type_key: str) -> tuple[list[str], list[str]]:
Expand Down
Loading