Task/hets 1366 pdt

[ionwyn]

Summary

This PR updates HETS server-side date handling so Pacific business dates and UTC/Pacific conversions continue to use UTC−7 after that change.

Changes

• Adds a permanent-Pacific rule to DateUtils:
  • for instants/local dates from the 2026-03-08 03:00 Pacific spring-forward onward, conversion uses a fixed UTC−7 offset;
  • dates before the effective date continue through the operating system's America/Vancouver / Windows Pacific timezone rules.
• Adds DateUtils.GetPacificNow() and replaces server-local/current-time use where HETS needs a Pacific calendar date.
• Keeps event/audit/other server metadata timestamps in UTC (e,g, server response timestamps).
• Pins the OpenShift .NET builder to the validated RHEL 8 image registry.redhat.io/rhel8/dotnet-80:8.0.129-1786585358 (amd64 digest sha256:37066d6a49a1eb97958fe2ecef672f8d992c7fc81215b6dca62c0b5ea7a1ad7b).
  • because for some reason :latest is pointing to April 2025 image...???

HETS features affected

Essentially everything that uses dates

• Fiscal-year and current-business-date decisions for districts, service areas, equipment usage, rotation documents, rental agreements, and equipment processing.
• District local-area lookup's current-date boundary.
• Equipment's eligibility calculation.
• Generated seniority lists, owner verification letters/reports, and mailing-label document/report dates and filenames.
• Rental-request expected dates, which now derive from the Pacific calendar date and are stored as UTC midnight.

Verification

• DateUtils test 6 passed, 0 failed.
• Ran the exact RHEL 8 builder image in OpenShift:
  • rpm -q tzdata → tzdata-2026c-1.el8_10.noarch
  • TZ=America/Vancouver date -d "2026-12-15 12:00:00 UTC" → 05:00 MST (still UTC−7).

What would happen if someone outside Pacific Time visits:

• browsers and user workstations: client-side local-time display/conversion still relies on each device's OS/browser timezone data;

The builder is intentionally pinned for reproducibility. Future RHEL image updates should be tested for tzdata version and the December-2026 conversion before changing the pinned tag.

Image tkaen

• Red Hat RHEL tzdata status — RHEL 8 received tzdata 2026b; the selected image was independently verified to contain the newer 2026c package.
• Red Hat .NET 8 RHEL 8 image.

[Copilot]

Pull request overview

Updates date handling for permanent Pacific time while preserving UTC storage semantics.

Changes:

• Adds permanent UTC−7 conversion logic and tests.
• Applies Pacific business dates across API, data, and import workflows.
• Pins the OpenShift .NET 8 build image.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Server/HetsImport/Import/ImportUtility.cs	Uses UTC audit timestamps.
Server/HetsImport/Import/ImportServiceArea.cs	Uses Pacific fiscal dates.
Server/HetsImport/Import/ImportRotationDoc.cs	Uses Pacific fiscal dates.
Server/HetsImport/Import/ImportOwner.cs	Uses Pacific year in generated keys.
Server/HetsImport/Import/ImportEquipUsage.cs	Uses Pacific fiscal dates.
Server/HetsImport/Import/ImportBlock.cs	Normalizes imported request timestamps.
Server/HetsData/Repositories/OwnerRepository.cs	Uses Pacific report dates.
Server/HetsData/Helpers/RentalAgreementHelper.cs	Uses Pacific fiscal-year calculations.
Server/HetsData/Helpers/EquipmentHelper.cs	Uses Pacific current year.
Server/HetsCommon/FiscalHelper.cs	Calculates fiscal years in Pacific time.
Server/HetsCommon/DateUtils.cs	Adds permanent UTC−7 handling and Pacific-now helper.
Server/HetsCommon.Tests/HetsCommon.Tests.csproj	Adds the common-library test project.
Server/HetsCommon.Tests/DateUtilsTests.cs	Tests permanent Pacific conversions.
Server/HetsApi/Controllers/RentalRequestController.cs	Uses Pacific document dates.
Server/HetsApi/Controllers/OwnerController.cs	Uses Pacific dates and key years.
Server/HetsApi/Controllers/EquipmentController.cs	Uses Pacific fiscal and document dates.
Server/HetsApi/Controllers/DistrictController.cs	Uses Pacific local and fiscal dates.
Server/HetsApi.sln	Registers the new test project.
openshift/api-build-config.yaml	Pins the .NET 8 builder image.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Server/HetsCommon/DateUtils.cs:66

• The XML summary now contradicts this branch: after the cutoff, the method returns fixed UTC−7 even when neither system time zone is available, rather than returning UTC. Update the public documentation so callers understand the cutoff and historical fallback behavior.

            if (utcDate >= PermanentPacificTimeEffectiveUtc)

[rogene-bcgov]

This is a bit odd. Should we use something like this (similar to DistrictController.cs:95):

ExpectedStartDate = DateUtils.ConvertPacificToUtcTime( new DateTime(now.Year, now.Month, now.Day, 0, 0, 0, DateTimeKind.Unspecified));

[ionwyn]

DistrictController isn't the same as this functionally.

• ExpectedStartDate and ExpectedEndDate are date-only values. Rental-request CRUD endpoints preserve calendar fields with DateUtils.AsUTC. Converting Pacific midnight like that would instead store 07:00Z under permanent UTC−7. It will trigger ExpectedStartDate <= endDtUtc filter which will exclude the record.

• AsUTC(GetPacificNow().Date) deliberately takes today’s Pacific calendar date and stores it as the established UTC date-only representation, so I think the current code is fine.