Repository navigation
fix: remove unused public write routes - #952
Merged
Merged
Conversation
- Remove POST /api/public/document and POST /api/public/comment. No client has called them since 2024-02-29: the public site is read-only since v2.7.37 and comments arrive through other systems. GET and HEAD public routes are unchanged. - Add input validation to the public CAC sign-up and remove-member routes: email must be a plain address string and the project id a 24-hex string. Stop logging email addresses. - Staff upload: require 24-hex string ids, always remove the temp file, and roll back the stored file by its exact key only when the document was not saved.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two public write routes that no client uses, and adds input validation to the remaining public and staff write paths.
POST /api/public/documentandPOST /api/public/comment. No client has called them since 2024-02-29. The public site is read-only since v2.7.37, and comments now arrive through other systems. Public GET and HEAD routes are unchanged.Tests cover the removed routes, the new validation and the upload clean-up.