Repository navigation
chore: delete routes with no caller - #945
Merged
Merged
Conversation
These routes have no caller in eagle-admin or eagle-public and had
no prod traffic in 30 days:
- topic and vc POST, PUT, DELETE
- POST /task and the api/tasks controller dir
- POST /jobs and DELETE /jobs/{jobId}
- POST /materialized-views/refresh (the CronJob runs
worker/matview-worker.js directly)
- inspection POST x3
- staff CAC routes x5
- DELETE /recentActivity (bulk form, always answered 400)
- GET /audit (no controller, so it was never routed)
GET routes for topic, vc, jobs and inspection items stay, as do the
public CAC sign-up and remove routes. POST /login/token stays because
the eagle-admin login screen calls it.
BREAKING CHANGE: the routes listed above now answer 404.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 13, 2026 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes routes that no frontend or job calls, with their handlers, helpers and tests.
Removed:
Kept: POST /login/token (eagle-admin login page calls it), topic and vc GET routes, the job queue and its GET routes, and the inspection DEMI push kinds used by the repush script and sweep.
Verified: yarn test (1584 pass; the 28 fewer tests covered deleted code). Callers checked in eagle-admin and eagle-public. Smoke tests parse but were not run against a deployment.
Wiki pages Async-Jobs, API-Architecture and Troubleshooting still mention the removed job and refresh routes and will be updated separately.