Repository navigation
feat(demi): log each landed DEMI push - #944
Merged
Merged
Conversation
Only failed pushes wrote a log line, so a pod log could not show that the push landed before the write response was sent. Each landed push logs one info line: [demiPush] mirrored <kind> <id>.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 9, 2026 23:37
# Conflicts: # api/helpers/actions.js
The mirrored guard hid the info line for pushes that landed in the same write as a failed one. result.landed already holds only the pushes that landed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only failed DEMI pushes wrote a log line, so the pod log could not show that a push landed before the write response was sent.
Each landed push now logs one info line through the default winston logger:
The line is written in
sendMirrorednext to the existing not-mirrored error line. Values that are not labelled pushes (null, or the bare resolved promise from a write that matched nothing) log nothing.Tests cover one push, two pushes in order, a failed push, no push, and the unlabelled case.