Repository navigation
refactor: move admin search page to DEMI - #975
Merged
Merged
Conversation
- Documents and Projects tabs read /documents and /projects with q, page, pageSize, count and native filter names. Only columns on the DEMI sort allow-list sort. The comment period filter is gone. - fullProjectResolver keeps its eagle-api read: DEMI rows hold only the current legislation version. - Drop the metrics page (eagle-api /audit has no controller), SearchService, OrgService.getByCompanyType and ApiService.head.
- One PROJECT_FILTERS map feeds the project list and search pages. - updateUrl escapes keywords, sort and filter values, so a ; ? # or % in them no longer breaks the URL on reload. - Application sort save names the documents it skips because they have no Eagle id. - Remove the unused PCP_COLLECTION.
Rows not in Eagle yet all have no _id, so matching on _id kept only the first of them. A re-edit of a row seen again also left the stale entry in place, so save sent the older sort order.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the eagle-admin search page to DEMI native routes and removes the last eagle-api read helpers (slice A7b of the frontend read migration). After this, the only eagle-api reads left are the
/api/configfetch,ProjectService.getForEditandfull-project.resolver.ts, which the edit forms keep until the write migration.Search page:
/documentsand the Projects tab reads/projects, each withq,page,pageSize,count=true, native filter names and one sort key from DEMI's allow-list. Documents sort ondatePostedanddisplayName, projects onname; other columns are not sortable./organizations?companyType=./search, which nothing calls now.Deleted:
search.service.ts,metrics/**and its route,OrgService.getByCompanyType,ApiService.head,PCP_COLLECTION.Also:
full-project.resolver.tscalls eagle-api search itself and skips ids that are not Eagle ids.PROJECT_FILTERSconst for the project list and the search page.TableTemplateUtils.updateUrlescapes keywords, sort and filter values for every caller.id, so rows without an Eagle id are all kept and a re-edited row sends its latest order.Checks:
yarn test-ci771 passed;yarn lintandnpm run buildclean. Anonymous parity on test: projects 203 match (176 known Track-mastered field differences), organizations 734 match, documents (project 5885109faaecd9001b81314c) 871 match. Staff parity and the signed-in browser check still need a staff token and login.