Repository navigation
refactor: move remaining admin reads to DEMI - #972
Merged
Merged
Conversation
- Remove eagle-api reads with no callers left: project getAll, getById, getPins, getGroupMembers; comment getById, getByPeriodId, getCountByPeriodId; comment period getById, getAllByProjectId; document getById, getByMultiId, downloadResource, downloadDocument. - Related documents, downloads and private Update thumbnails read DEMI (by id, presigned URL). - Project groups use the resolved project's demiId instead of a second projects read. - toLegacyProject maps projectState to status, address to location. - One eagleWriteId in demi-ids; saveBlob in shared utils; one DEMI_MAX_PAGE_SIZE constant; drop unused getFormattedTime. - Pin the AppComponent dropdown spec host to the viewport: text the karma reporter drew above the fixture pushed the toggle out of the 437px frame, which the hide modifier treats as hidden.
- Application sort lists /documents with sort=sortOrder and native type, milestone and phase filters. List rows match on type too, so 'Application Review' no longer resolves to the phase id. - Publish checks read isPublished: DEMI rows carry no read list. - One native name sort in table-template-utils replaces orgSort and its copies; shared Proponent type. - Drop unused jszip.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the remaining eagle-api reads in eagle-admin to DEMI native routes (slice A7a of the frontend read migration).
Reads moved:
/groups?project=<demiId>from the resolved project; no second projects call.getAll,getById,getPins,getGroupMembers, comment and comment periodgetById, documentgetById,getByMultiId,downloadResource,downloadDocumentare deleted./documents?project=<demiId>&sort=sortOrder&documentSource=PROJECTwith type, milestone and phase filters. The old List match by name and legislation picked the wrong 2002 row ('Application Review' is both a phase and a milestone); the filter now matches on type too.toLegacyProjectmapsprojectStatetostatusandaddresstolocation.isPublicDocumentandblocksPublishreadisPublishedon DEMI rows, since DEMI hidesread.Cleanup:
eagleWriteId, onesaveBlob, oneDEMI_MAX_PAGE_SIZE, one sharednativeSort/tableSort;orgSortandgetFormattedTimeremoved;jszipdropped.lastNamecolumn it served.Still on eagle-api, by decision: project and document edit-form loads, archived detail,
fullProjectResolver, and the search page (next slice).Checks:
yarn test-ci732 passed, 1 skipped;yarn lintandnpm run buildclean; anonymous document parity on test, project 5885109faaecd9001b81314c: match 871, missing 0, extra 0. Staff parity and the signed-in browser check still need a staff token and login.