Repository navigation
feat(activity): read updates from DEMI - #971
Merged
Merged
Conversation
- Update lists, the project Updates tab and the edit form read /updates and /updates/:id. Project and type filters use DEMI names; only Date stays sortable. - The date range and C&E filters are gone: DEMI cannot filter updates by either. The project filter takes one project. - The edit form reads projects, project notifications, documents and comment periods from DEMI, by DEMI project id. - Writes stay on eagle-api. A native row maps to its Eagle id and Eagle project id. Saving an edit leaves the C&E flag alone, since DEMI rows do not carry it.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 04:33
DEMI update rows carry no C&E flag, so the edit form loaded it as off and the save dropped it. Hide the toggle when editing; eagle-api keeps the stored value. Log and show a toast when the update list fails to load, before going to search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activity list, the project Updates tab and the update edit form now read updates from DEMI
/updatesin DEMI's own row shape. Saves still go to eagle-api. A small mapper next to the save call turns a DEMI row into the body eagle-api expects.Changes:
models/demi/update.tsholds the DEMI update type, the sort value and the Eagle id helpers.recent-activity.tsgainslistandgetNative, plustoEagleUpdateBodyfor saves. A native row is sent with_idset to its Eagle id andprojectset to the parent's Eagle id./updates?project=<Eagle id>. Only Date stays sortable.GET /projects/<id>. An edit save leaves the C&E flag alone, because DEMI rows do not carry it./updatesfilters only on project and type, and takes one project value.eagle-api reads removed:
projectService.getAll,getSearchResultsfor RecentActivity and Document,getItemRecentActivity,projectService.getById,getAllByProjectIdand the eagle-api notification-project list in these screens.Checks:
yarn test-ci(696 passed),yarn lint,yarn build. Anonymous parity for recent activity on test: 4 match, 0 missing, 0 extra, 0 field differences. Staff parity and a signed-in browser check still need a staff login.