Repository navigation
feat: read project notifications from DEMI - #970
Merged
Merged
Conversation
- List, detail, resolver and documents fallback read /notifications and /notifications/:id; detail lists its documents from /documents. - Writes stay on eagle-api; a native row is mapped to the Eagle body first. Notification ids are Eagle ids, and associatedProjectId is already an Eagle project id. - Only Name can be sorted: DEMI sorts notifications by name and received date only.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 04:26
save() and add() take only Eagle-shaped bodies. No caller passed a native DEMI row, so the mapping branch was unused. Add a spec for the notification detail screen: the DEMI document read and the publish/unpublish skip of documents with no Eagle id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project notification list, resolver and detail screens now read from DEMI's native
/notificationsroutes instead of eagle-api._idcomes from the Eagle id.readcomes fromisPublished, because anonymous rows leavereadout.pcp,isMet,metURLand the period dates, because the eagle-api PUT clears any of them it is not sent.toEagleNotification, sits besidesaveandaddand builds the eagle-api body with the Eagle ids.eagle-api reads removed: the notification list and get, the notification search on the list screen, the document search on the detail screen, and the notification reads in the resolver and documents tab.
Tests: the model mapping and sort rule, the write mapper (PUT goes to the Eagle id with the Eagle project id), the list query, the resolver and the documents fallback.