Repository navigation
feat: read comment periods from DEMI - #969
Merged
Merged
Conversation
- List, resolver and details read DEMI comment periods. The list filters on the DEMI project id (notification id for notification periods) and sorts only on dateStarted or dateCompleted. - Comment export calls DEMI /commentperiods/:id/comments/export; the proponent file sends audience=proponent. - ENGAGE periods, periods with no Eagle id and tokens without the staff role are read-only.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 03:25
- Cover the edit-route guard that keeps read-only periods out of the form. - Remove DocumentService.exportComments; the details tab exports through DEMI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment period list, the period resolver and the comment exports now read from DEMI instead of eagle-api.
toLegacyCommentPeriod, turns a DEMI period into the shape the screens already use. It addsdemiIdandreadOnly. Before an edit is saved, these fields anduserCanare removed, so they never reach Eagle.readOnlyis true for ENGAGE periods, periods with no Eagle id, rows read without staff fields, and users without thesysadminrole. On read-only periods, Edit, Add a comment, Publish/Un-Publish and Delete are hidden. Opening the edit route for one returns you to the previous page with a message.audience=proponent. A failed export shows a message and is logged.eagle-api reads removed: the period list by project, period by id, and the comment export.
Tests: export URLs and the failure case, the resolver shape and redirect, list parameters,
readOnlyfrom roles, the save body, and the menu for Eagle and ENGAGE periods.