Repository navigation
feat: read document pickers from DEMI - #968
Merged
Merged
Conversation
- Document edit maps native rows to Eagle field names and writes by Eagle document and project id; a row with no Eagle record shows no save and says why. - Comment period and notification document pickers read DEMI /documents by the DEMI project id or the notification id. Rows with no Eagle id are left out, since links and publish go to eagle-api. - Columns DEMI cannot sort by are no longer sortable.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 03:25
- Send documentSource (PROJECT, or PROJECT-NOTIFICATION) so comment attachments stay out of the comment period picker and the notification document list. - Keep rows with no Eagle id on the page so paging and totals match DEMI; their checkbox is disabled and select-all skips them. - Toast and log when the DEMI project lookup fails.
DEMI main answers 400 to a documentSource filter, so the pickers stop sending it. Rows of another source, such as comment attachments, and rows with no Eagle id stay on the page with their checkbox disabled, and select-all skips them.
DEMI accepts the documentSource filter now, so pages and totals hold only the screen's own source. The per-row source check stays as a second guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document edit now works on DEMI rows, and the two document pickers read DEMI's native
/documents.Document edit:
togglePublishbuilt its request inside the per-row loop.Pickers:
project. Status readsisPublished. The Author and Status columns no longer sort.Known gap: the comment period picker used to send
documentSource, which DEMI does not accept yet. A follow-up adds it once DEMI supports it.Uploads are unchanged.
Tests: edit saves by Eagle id for both row shapes, hidden Save for rows with no Eagle id, the row mapper, and the query each picker sends.