Repository navigation
feat: read the document list and detail from DEMI - #967
Merged
Merged
Conversation
- List sends the DEMI project id, native filter names and one sort key (datePosted or displayName); other columns are not sortable. - Writes (publish, unpublish, delete, feature) use the Eagle id and skip rows that have none. - Detail opens published files inline through DEMI; unpublished files download, because a new-tab open carries no bearer. - Hit counts and labels are gone: DEMI rows do not carry them.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 03:25
- Staff list sends documentSource=PROJECT, as the old search did. - Specs cover the project id fallback on rows, the publish guard for rows with no Eagle id, and featuring from the table rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project documents list, the document detail page and the document resolver now read from DEMI's native
/documentsroutes instead of eagle-api.List:
project(the DEMI project id),page,pageSize,count=trueandq.milestoneId,typeId,documentAuthorTypeId,projectPhaseId,datePostedStartanddatePostedEnd.Detail:
"Open in tab" opens published files inline from DEMI. Unpublished files show "Open in a tab needs a published file. Use Download." in place of Open.
Still on eagle-api: the application sort screen, because DEMI documents have no
sortOrderyet, and the copy-link URL.Known gap: the old list sent
documentSource: PROJECT, which DEMI does not accept yet. Until it does, the staff list may include comment attachments. A follow-up sends the filter once DEMI supports it.Tests: list query parameters, the detail fields, and the resolver shape.