Repository navigation
feat: read comment review from DEMI - #966
Merged
Merged
Conversation
- Review tab lists /comments by period and eaoStatus. Only the date column sorts, since DEMI sorts comments by dateAdded only. - Comment resolver returns the native row plus its attachments from /documents?ids=. Next and pending come from a count=true read. - Saves stay on eagle-api under the Eagle comment and document ids. - Save/Next reloads the form for the next comment. The component is reused, so its setup used to run only once. - Period id comes from the route, not the period resolver row.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 03:23
Count published comments over the whole period. A failed read used to fall back to an empty page, which marked the period deletable. Also test that Save/Next reloads the form for the next comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment review screens now read from DEMI's native routes instead of eagle-api.
/commentsby period, with oneeaoStatusparameter per selected status. Only the date column sorts, because DEMI sorts comments bydateAddedonly. The default sort is newest first./documents?ids=.count=trueread.PUT comment/<id>, because that call also stores the notes anddatePosted.Fixed along the way: Save/Next reuses the component, so the form used to keep showing the previous comment. The form now reloads whenever the comment changes.
Tests: specs for the resolver, the review tab query, and the review form (next and pending, save by Eagle id, attachments published by Eagle id).