Repository navigation
feat(orgs): read organizations from DEMI - #959
Merged
Merged
Conversation
- The organization list, the link-organization picker and the edit form read DEMI /organizations instead of the eagle-api search endpoint. - DEMI sorts organizations on name only, so the Organization Type and Company Legal columns are no longer sortable. - Writes still go to eagle-api. A native row passed to save or add is converted to Eagle field names first. - getByCompanyType stays for its callers outside the organization screens.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
October 14, 2026 02:43
A parent organization DEMI cannot return no longer shows an error toast on a form that loads fine. The form keeps the parent link and shows its id as the name. Only a failed read of the organization being edited shows an error.
The add/edit form sends native-shaped input and OrgService converts it to the eagle-api body, so the native-to-Eagle mapper is the one path for organization writes. A new row with no id maps to an Eagle body with a null _id, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The organizations list, the add/edit organization form and the link-organization picker now read from DEMI
/organizationsinstead of the eagle-api search and item endpoints.OrgServicehas nativelistOrganizations,getOrganizationandorgSortmethods. DEMI sorts organizations only byname, so the Organization Type and Company Legal columns are no longer sortable.companyTypevalues._idis sent unchanged.getByCompanyTypestays for its other callers until they move.Selecting more than one organization type needs DEMI to accept a repeated
companyType; that change is in a separate DEMI PR.Parity on test (anonymous organization list): 734 matched, 0 missing, 0 extra, 0 field differences.