Repository navigation
Cursor/restore by mnemonic 9650 - #15
Merged
Merged
Conversation
Address still-valid security and correctness issues: relay coin/auth, identity PoP ownership, PSBT signature integrity and CAS writes, client verification fail-closed join records and required SendIntent, payment verification by txid, token metadata no node fallback, PayJoin fee-rate cap, and R10 scoped to spent inputs. Co-authored-by: nghiacc <nghiacc@yahoo.com>
Users should not need a wallet ID: derive candidate xpubs/copayerIds from the recovery phrase (including XEC 899/1899/145 variants), look them up in the server DB, and re-attach. Align copayerId with BWC sha256(coin+xpub) so migrated Pi wallets authenticate correctly. Co-authored-by: nghiacc <nghiacc@yahoo.com>
Preserve envelope/PSBT columns from the Pi dump so db:push does not prompt for destructive drops on deploy. Co-authored-by: nghiacc <nghiacc@yahoo.com>
…tore - Keep full main + PR13 v5/token/DER-auth stack on restore branch - Materialize 0..address_index-1 and 0..change_address_index-1 addresses so migrated v1 wallets expose their historical addresses/funds and do not skip m/0/0 when restored by mnemonic only Co-authored-by: nghiacc <nghiacc@yahoo.com>
Wallet detail was rendering stale context balance (0 after restore) while tokens came from a fresh /balance call. Use the loaded spendable amount, refresh balances when wallets are added, and disable nginx/ proxy buffering on notification SSE so status leaves Connecting. Co-authored-by: nghiacc <nghiacc@yahoo.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 29
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restore by mnemonic without wallet id.