Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
name: Build 🛠️
permissions:
contents: read
pull-requests: write

on:
workflow_dispatch: # can call manually
Expand All @@ -12,7 +15,7 @@ jobs:
name: Run the tests
strategy:
matrix:
node-version: ['18.x', '20.x']
node-version: ['24.x', '26.x']

runs-on: ubuntu-latest

Expand All @@ -27,3 +30,31 @@ jobs:
- run: npm run lint
- run: npm run build
- run: npm run test

comment-success-on-pr:
if: success()
needs: test
runs-on: ubuntu-latest
steps:
- name: Add Success Comment to PR
uses: marocchino/sticky-pull-request-comment@v2
with:
header: build
hide_and_recreate: true
hide_classify: "OUTDATED"
message: |
Lint, build and test passing for commit ${{ github.event.pull_request.head.sha }} 🚀

comment-failure-on-pr:
if: failure()
needs: test
runs-on: ubuntu-latest
steps:
- name: Add Failure Comment to PR
uses: marocchino/sticky-pull-request-comment@v2
with:
header: build
hide_and_recreate: true
hide_classify: "OUTDATED"
message: |
Lint, build and test FAILING for commit ${{ github.event.pull_request.head.sha }} 💥
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ A web page showcasing adhere-lib is available at https://bbc.github.io/Adhere/
## Setup

```Shell
nvm install 20.11.0
nvm use 20.11.0
nvm install 24
nvm use 24
nvm install-latest-npm
```

(latest npm is currently 10.8.1)
(latest npm is currently 12.0.2)

`cd` to project dir

Expand Down Expand Up @@ -186,4 +186,4 @@ This is licensed under the Apache 2.0 License.

## Copyright

Copyright (c) 2021 BBC
Copyright (c) 2026 BBC
4 changes: 2 additions & 2 deletions build-pr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
set -e

source /usr/local/nvm/nvm.sh
nvm install 20.11.0
nvm use 20.11.0
nvm install 24
nvm use 24
nvm install-latest-npm

# Install & Build
Expand Down
4 changes: 2 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
set -e

source /usr/local/nvm/nvm.sh
nvm install 20.11.0
nvm use 20.11.0
nvm install 24
nvm use 24
nvm install-latest-npm

# Install & Build
Expand Down
10 changes: 5 additions & 5 deletions dist/bin/js/bundle.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 1 addition & 36 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "adhere-lib",
"version": "0.10.1",
"version": "0.10.2",
"repository": {
"type": "git",
"url": "https://github.com/bbc/adhere-lib"
Expand All @@ -10,7 +10,7 @@
"main": "./dist/bin/js/bundle.js",
"type": "module",
"engines": {
"node": ">=18.0"
"node": ">=24.0"
},
"resolve": {
"extensions": [
Expand Down
Loading