Conversation
Include --copt with --conlyopt or --cxxopt in the C/C++ toolchain variables used to derive CFLAGS and CXXFLAGS. This makes build script native compilation honor Bazel compiler options while keeping language-specific flags separate. Add an analysis regression for all three options. The regression fails before the fix; all 31 cc_args_and_env tests pass on Bazel 9 afterward. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted to the intended repository in hermeticbuild#64. This PR is closed.
Include
--copt,--conlyopt, and--cxxoptwhen derivingCFLAGSandCXXFLAGSfor Cargo build scripts. These flags were omitted from the C/C++ toolchain variables, so native code compiled by a build script could use different defines and compiler options from Bazel C/C++ targets. Keep C-only and C++-only flags separate.Added a regression for common and language-specific flags. It fails before the fix; all 32 tests in
//cargo/tests/cargo_build_script/cc_args_and_env:allpass on Bazel 9 afterward.Assisted by OpenAI Codex.