Conversation
Pass skip_expanding_rustc_env through both construct_arguments calls so pipelined compilation does not expand literal environment values for custom rules. Add an analysis regression for literal make-variable syntax. The regression fails before the fix; all eight pipelined_compilation tests pass on Bazel 9 afterward. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted to the intended repository in hermeticbuild#63. This PR is closed.
Pass
skip_expanding_rustc_envto metadata argument construction as well as the main compilation. With pipelining enabled, custom rules that set this option still expanded literal$(...)values and could fail during analysis.Added an analysis test that checks the unchanged environment in both Rustc actions. The test fails before the fix; all 14 tests in
//test/unit/pipelined_compilation:allpass on Bazel 9 afterward.Assisted by OpenAI Codex.