Repository navigation
Conversation
The `//:bzl` filegroup re-exported `.bzl` files from `@bazel_tools//tools/python` that rules_python doesn't load, and the `_bootstrap_template` fallback of the executable rules pointed to Bazel's frozen copy of the bootstrap template even though rules_python ships its own. Bazel would like to remove the unused files from `@bazel_tools`, which these references currently block.
fmeum
marked this pull request as ready for review
October 10, 2026 13:36
Collaborator
|
Hrm. It seems that old bootstrap is somehow load bearing for windows >.< . I think the proper fix is to get rid of that implicit attribute entirely. Lets make a quick try to just remove that entire Can you split the |
Remove the unsupported 1-stage bootstrap codepath and _bootstrap_template attribute from py_executable.bzl. Configure _magic_sentinel_runtime with supports_build_time_venv = False and resolve --python_path in _get_interpreter_path so Windows runtime_env_toolchain uses the standard 2-stage bootstrap and runtime venv creation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel is trimming unused content from
@bazel_tools(bazelbuild/bazel#31549, bazelbuild/bazel#31692). Two references from rules_python currently block the removal of@bazel_tools//tools/pythonfiles that are otherwise unused://:bzlfilegroup re-exports@bazel_tools//tools/python:{python_version,srcs_version,toolchain,utils}.bzl. rules_python doesn't load any of them;srcs_version.bzl,toolchain.bzlandutils.bzlhave no remaining users (py_runtime_pairintoolchain.bzljust fails since Bazel 8). Before://:bzlcontains these four files. After: it only contains rules_python's own.bzlfiles._bootstrap_templateattribute of the executable rules, which is only used when no Python runtime is available, defaulted to@bazel_tools//tools/python:python_bootstrap_template.txt. rules_python already ships its own, newer copy of that template as//python/private:python_bootstrap_template.txt, whichpy_runtimeuses by default. Before: the fallback uses Bazel's frozen template. After: it uses rules_python's.The remaining references to
@bazel_tools//tools/python(the toolchain type, thepython_versionflag and the interpreter path constraints) are unchanged.