Repository navigation
build(release): ignore completed release issues when adding backports - #4225
Merged
rickeylev merged 1 commit intoOct 6, 2026
Merged
Conversation
When someone comments `/backport` on a PR, `add-backports` auto-discovers the active release tracking issue by looking for open issues with the release label. It only checked that an issue was open, not whether the release it tracks had already shipped. A release issue whose "Tag Final" task was done but that nobody closed therefore kept receiving new backports. Auto-discovery now ignores open issues whose "Tag Final" task is done and emits a workflow warning suggesting the issue be closed. If that leaves no open issue, the tool creates a new patch release tracking issue, as it does when none is open. A complete issue sitting next to an active one no longer triggers the "multiple open issues" error. Explicitly passing `--issue` is unchanged. `sync-changelog` and `create-release-issue` still treat any open issue as active; the new `is_release_complete()` helper can be reused there in a follow-up.
rickeylev
enabled auto-merge
October 6, 2026 03:49
rickeylev
added a commit
that referenced
this pull request
Oct 6, 2026
PR #4225 taught `add-backports` to skip open release tracking issues whose "Tag Final" task is done, but `sync-changelog` and `create-release-issue` still treated any open issue as the active release. A tagged-but-unclosed issue therefore made `sync-changelog` auto-discovery fail with "multiple open issues" and blocked `create-release-issue` from starting the next release. Move the active/complete split into a shared `partition_open_tracking_issues()` on the GitHub interface and use it from all three commands. Each warns about complete-but-open issues so someone closes them; only active issues count for auto-discovery and for the "release already in progress" guard. * Also adds tests for `create-release-issue`, which had none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When someone comments
/backporton a PR,add-backportsauto-discovers the active release tracking issue by looking for open
issues with the release label. It only checked that an issue was open,
not whether the release it tracks had already shipped. A release issue
whose "Tag Final" task was done but that nobody closed therefore kept
receiving new backports.
Auto-discovery now ignores open issues whose "Tag Final" task is done
and emits a workflow warning suggesting the issue be closed. If that
leaves no open issue, the tool creates a new patch release tracking
issue, as it does when none is open. A complete issue sitting next to
an active one no longer triggers the "multiple open issues" error.
Explicitly passing
--issueis unchanged.sync-changelogandcreate-release-issuestill treat any open issue as active; the newis_release_complete()helper can be reused there in a follow-up.