agents: refine Starlark, workspace merge, and CI monitor rules - #4214
Merged
rickeylev merged 1 commit intoOct 5, 2026
Merged
Conversation
Prevent duplicate Label() definitions, mid-merge stashing issues, and false-positive CI monitor process checks. Require reusing `labels.<NAME>` from `common_labels.bzl` and preferring `types.is_*` from `@bazel_skylib//lib:types.bzl` in Starlark rules and review prompts, document committing or stashing before `git merge upstream/main`, and use a bracketed character class in `pgrep -af` to avoid matching the subshell command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent duplicate Label() definitions, mid-merge stashing issues, and
false-positive CI monitor process checks.
Require reusing
labels.<NAME>fromcommon_labels.bzland preferringtypes.is_*from@bazel_skylib//lib:types.bzlin Starlark rules andreview prompts, document committing or stashing before
git merge upstream/main, and use a bracketed character class inpgrep -aftoavoid matching the subshell command line.