Repository navigation
Conversation
Cargo 1.97 added a $comment key to .cargo-checksum.json, so the patch that rewrote the whole one-line file no longer applies. Patch only libretro.h and update its checksum with sed in a post-patch hook, which does not depend on the layout of the json file. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012SzrKCG5QK38mhxCGtiGQR
Collaborator
|
As per the buildroot comment, we don't need this upgrade yet and no changes will be considered to the build system until v45. This is not a bug that requires our attention for v44. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
libretro-holanifailing to patch with cargo >= 1.97 (see batocera-linux/buildroot#1215).001-fix-build-with-clang-22.patchmodifiedlibretro.hand also rewrote the whole one-lineVENDOR/libretro-rs-ffi/.cargo-checksum.jsonto update the header's checksum. Cargo 1.97 added a$commentkey to that file, so the second hunk no longer applies:The patch now only touches
libretro.h, and aPOST_PATCH_HOOKupdates the checksum withsed. It doesn't depend on the layout of the json, so it works with both the old and new cargo vendoring output.Testing
libretro.hhashes to the value the hook writes (220bd363...).https://claude.ai/code/session_012SzrKCG5QK38mhxCGtiGQR