Harden history directory and append writes - #214
Merged
codeforester merged 2 commits intoAug 18, 2026
Merged
Conversation
codeforester
deleted the
security/210-20260818-history-directory-and-append-only-writes-bypass-the-package
branch
August 18, 2026 08:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #210.
0700permissions.O_NOFOLLOWand directory-relative handles where supported.0600permissions to the opened file descriptor, including the Windows lock sidecar path.This closes the gap between history writes and the package's existing private-file hardening without changing the history schema or append-locking behavior.
Validation
uv run --extra dev --extra quality pytest— 413 passed, 5 skippeduv run --extra quality ruff check lib/python/base_cli/history.py tests/test_history.pyuv run --extra dev mypy lib/python/base_cli/history.py./tests/validate.sh