Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Pull request overview
Updates Staticcheck to support Go 1.27 while retaining deterministic toolchain pinning.
Changes:
- Pins Staticcheck to 2026.2.1.
- Pins its toolchain to Go 1.27.0.
- Updates the explanatory workflow comment.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jeremy
force-pushed
the
ci-staticcheck-2026-2
branch
from
August 31, 2026 09:37
ea7a471 to
1d809d2
Compare
The step pinned GOTOOLCHAIN to go1.26.6 because staticcheck 2025.1.1 cannot decode go1.27 export data, so the analysis has been running one Go major behind everything else in the job since the day 1.27 became stable. staticcheck 2026.2.1 (honnef.co/go/tools v0.8.1, 2026-08-21) understands it: verified locally under go1.27.0, clean on ./..., while 2025.1.1 under the same toolchain still fails with the export-data error the comment describes. Both raised together, as the comment says to; the pattern stays so the next Go major cannot break the job the same way.
2026.2 (v0.8.0) added go1.27 support — verified it also runs clean on this module under go1.27.0 — and 2026.2.1 is its current patch release. The comment called the patch the first compatible release, which misstates the history; the selected version is unchanged.
jeremy
force-pushed
the
ci-staticcheck-2026-2
branch
from
September 3, 2026 01:58
1d809d2 to
88703b5
Compare
jeremy
enabled auto-merge (squash)
September 3, 2026 01:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
staticcheckstep pinsGOTOOLCHAIN: go1.26.6because 2025.1.1 cannot decode go1.27 export data — so since 1.27 went stable the analysis has been running one Go major behind the rest of the job and the wholego-testmatrix.The upstream gate has opened: staticcheck 2026.2.1 (
honnef.co/go/toolsv0.8.1, released 2026-08-21) understands go1.27. Verified locally before opening this:Raises both together as the step's comment prescribes, and keeps the pin pattern so the next Go major cannot break the job the same way. No other step changes;
govulncheckv1.7.0 is still latest.