Say which SDK release the pin is, now that it is one - #735
Merged
Merged
Conversation
The SDK version note still explained that the pin could not be a release tag because the event-feed operations were unreleased. They shipped in v0.19.0, and go.mod has named that tag since #729, so the paragraph described the opposite of what the file two directories over says.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approved
The documentation now accurately matches the repository’s v0.19.0 SDK pin.
Pull request overview
Updates API-COVERAGE.md to reflect the basecamp-sdk v0.19.0 release.
Changes:
- Replaces the obsolete unreleased pseudo-version note.
- Documentation-only; no code or dependency changes.
File summaries
| File | Description |
|---|---|
API-COVERAGE.md |
Corrects the SDK version documentation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API-COVERAGE.mdstill carried this:Every clause of that is now false. The operations shipped in basecamp-sdk v0.19.0,
go.modhas readgithub.com/basecamp/basecamp-sdk/go v0.19.0since #729, andinternal/version/sdk-provenance.jsonrecords the tag and its commit. The paragraph described the opposite of what the file two directories over says.Why this is a separate PR
#733 carried this correction alongside the re-pin itself. #729 then did the re-pin —
go.mod,go.sum, both provenance files and the vendorHash — and landed first, which leaves #733 with nothing but this paragraph and a conflict. #733 is obsolete and can be closed; this is the one piece of it worth keeping.Documentation only. No code, no dependency, no generated file.
Summary by cubic
Updates
API-COVERAGE.mdso the SDK version note matches reality: the pin is now basecamp-sdk v0.19.0, the release that ships the event-feed operations, not amainpseudo-version.Written for commit 22c876f. Summary will update on new commits.