Skip to content

Bump github.com/basecamp/cli for the keyring probe race fix #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 3 commits into from
Aug 28, 2026
Merged

Bump github.com/basecamp/cli for the keyring probe race fix #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b59bbf
Bump github.com/basecamp/cli for the keyring probe race fix
jeremy Aug 28, 2026
690dc28
Advance flake.lock and vendorHash for the Go 1.26.7 floor
jeremy Aug 28, 2026
f1f7cfe
Document the Go 1.26.7 floor and retire the Termux go.mod workaround
jeremy Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ The `go.work` file is gitignored - your local setup won't affect the repo.

## Requirements

- Go 1.26+
- Go 1.26.7+
- [bats-core](https://github.com/bats-core/bats-core) for integration tests
- [golangci-lint](https://golangci-lint.run/) for linting
- [jq](https://jqlang.github.io/jq/) for CLI surface checks
Expand Down
6 changes: 3 additions & 3 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
module github.com/basecamp/basecamp-cli

go 1.26.5

toolchain go1.26.7
go 1.26.7
Comment thread
jeremy marked this conversation as resolved.
Comment thread
jeremy marked this conversation as resolved.
Comment thread
jeremy marked this conversation as resolved.

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the remaining Go requirement

For contributors or agents relying on the repository instructions, the root AGENTS.md still advertises Go 1.26+ even though this directive now rejects Go 1.26.0–1.26.6 when automatic toolchain switching is unavailable. The final tree updates CONTRIBUTING.md and install.md, but that newly documented 1.26.7 floor remains inconsistent here; update the root requirement as well.

AGENTS.md reference: AGENTS.md:L108-L108

Useful? React with 👍 / 👎.


require (
charm.land/bubbles/v2 v2.2.0
charm.land/bubbletea/v2 v2.0.9
charm.land/lipgloss/v2 v2.0.6
github.com/basecamp/basecamp-sdk/go v0.14.0
github.com/basecamp/cli v0.2.2-0.20260728023309-04e401b12c6c
github.com/basecamp/cli v0.2.2-0.20260828032417-844e9f965144
Comment thread
jeremy marked this conversation as resolved.
github.com/charmbracelet/bubbles v1.0.0
github.com/charmbracelet/glamour v1.0.0
github.com/charmbracelet/huh v1.0.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ github.com/aymerick/douceur v0.2.0 h1:Mv+mAeH1Q+n9Fr+oyamOlAkUNPWPlA8PPGR0QAaYuP
github.com/aymerick/douceur v0.2.0/go.mod h1:wlT5vV2O3h55X9m7iVYN0TBM0NH/MmbLnd30/FjWUq4=
github.com/basecamp/basecamp-sdk/go v0.14.0 h1:Jyzmu3ucqwVe+YNC1zWJBOdPjBaTapyZWX7y0cAvaYo=
github.com/basecamp/basecamp-sdk/go v0.14.0/go.mod h1:BlEtZTW78rOY5geVtKaCiccYT9Jz+QGgPuXLo2pROWk=
github.com/basecamp/cli v0.2.2-0.20260728023309-04e401b12c6c h1:+5sQBl8sqYoD1Qhwsibn8sBCKWPyZ9NDez6mnuo9Afo=
github.com/basecamp/cli v0.2.2-0.20260728023309-04e401b12c6c/go.mod h1:EK1Dba6DEw8ZAilVBpf/jri3ONDV7LQkLACSDe73f/c=
github.com/basecamp/cli v0.2.2-0.20260828032417-844e9f965144 h1:ZJxdRGsb6QyuXNFge6wVx7772e8kDHC9a72aBokaTwM=
github.com/basecamp/cli v0.2.2-0.20260828032417-844e9f965144/go.mod h1:iTBTaWvsPEFIcZfkxQHEfISyJ6sZ7036K6bNx0RY3EE=
github.com/blang/semver v3.5.1+incompatible h1:cQNTCjp13qL8KC3Nbxr/y2Bqb63oX6wdnnjpJbkM4JQ=
github.com/blang/semver v3.5.1+incompatible/go.mod h1:kRBLl5iJ+tD4TcOOxsy/0fnwebNt5EWlYSAyrTnjyyk=
github.com/bmatcuk/doublestar v1.1.1/go.mod h1:UD6OnuiIn0yFxxA2le/rnRU1G4RaI4UvFv1sNto9p6w=
Expand Down
7 changes: 4 additions & 3 deletions install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ cd basecamp-cli
go build -o basecamp ./cmd/basecamp # or: make build → bin/basecamp
```

Then move the `basecamp` binary onto your PATH. Requires Go 1.26+; if your
Termux Go is an earlier patch release, lower the `go` line in `go.mod` to
match the version you have installed.
Then move the `basecamp` binary onto your PATH. Requires Go 1.26.7+ — the
pinned `github.com/basecamp/cli` module sets that floor, so lowering the `go`
line in `go.mod` no longer helps. If your Termux Go is an earlier patch
release, upgrade the `golang` package first (`pkg upgrade golang`).
2 changes: 1 addition & 1 deletion nix/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildGoModule.override { go = go_1_26; } (finalAttrs: {
src = lib.cleanSource ./..;

# To update: set to lib.fakeHash, run `nix build`, use the hash from the error.
vendorHash = "sha256-zZ3+CTLZ4hOkA2IvEbgSj5hQhTDn0agUDVrT+4EN1co=";
vendorHash = "sha256-6TAf9LSEQ8AEYAzFLCHN3mHT8gGoOGQ5zcsy55P2luc=";

subPackages = [ "cmd/basecamp" ];

Expand Down